Support duet format #P1 #P2 #107
Comments
|
Just checked the source code of major karaoke players. USDX + USWP support the original USDX-CMD format (P command + space + bitmask = P 1, P 2, P 3). Vocaluxe and Performous support it too, but also support a tag format (bitmasks #P1, #P2, #P3) that is incompatible with USDX and USWP and is logged as error. Vocaluxe further uses the #DUETSINGERP1 tag (with and without space). Tags imo represent header information. Restricting tags to a header section allows for quickly loading song info. So I'll go with this:
|
|
Hi! We will drop the P3 support in the next version of USWP, in fact we only create duets using P1 and P2 in our website. |
* revised open/split/merge tracks (in-memory, no auto-save) #110 * add 'open folder' menu entry #114 * add autocorrect for invalid player tags (#P1 --> P 1) #107 * add 'save as' for single track and multitrack #31 * support third (P 4)+ forth player (P 8), number is bitmask, see https://yass-along.com/duets/ * show matching pages for all tracks, compared to active track * add missing action shortcuts to menu * rm interalways store tracks sequentially ('duet-sequential') * rm proprietary [VERSION] handling in filename and title * minor: clean code (rm game mode artefacts, rm intellij warnings) * translate + fix sidebar drag * fix open/close/reopen issues * fix undo state (multi table) * fix multitrack icon in library * fix repaint issues in editor * fix play button location for overlapping notes * fix scale in track display * fix stall when try going after end
|
Done in release 2.4.1, not released yet @TeLiXj see my writeup at https://yass-along.com/duets I have chosen to stay compatible with "P 3", but do not use it when saving data. Singer 3 is stored as "P 4". Implementation on your side should be easy, same holds for the other projects. Example: |
|
Just released new version; wish you a happy christmas! |
Duets are recognized when they have this format:
The number is a bit mask, bit 0 = P1, bit 1 = P2. (https://yass-along.com/duets/)
Yass checks if singers share exactly the same line, and uses
P 3if possible.Duets are not recognized when they have that format:
I am not sure if #P3 is used, and if so, does is target P1+P2 or simply P3?
Would it be okay to simply rewrite the tags when loading?
#P1 --> P 1
#P2 --> P 2
#P3 --> ??
#P4 --> ??
Or preserve that format when the files are stored?
The text was updated successfully, but these errors were encountered: