Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save points as file from graph loses precision (Trac #997) #1068

Closed
pkienzle opened this issue Mar 30, 2019 · 6 comments
Closed

save points as file from graph loses precision (Trac #997) #1068

pkienzle opened this issue Mar 30, 2019 · 6 comments
Assignees
Labels
Defect Bug or undesirable behaviour Minor Small job
Milestone

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

When using the graph menu option to save points from graph to a file, it is only saving about 6 digits of precision rather than full 15 digits available. Should use %.15g or maybe %.15e rather than %g for the number format.

Migrated from http://trac.sasview.org/ticket/997

{
    "status": "new",
    "changetime": "2017-10-27T08:31:56",
    "_ts": "2017-10-27 08:31:56.079152+00:00",
    "description": "When using the graph menu option to save points from graph to a file, it is only saving about 6 digits of precision rather than full 15 digits available.  Should use %.15g or maybe %.15e rather than %g for the number format.\n\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2017-09-19T14:50:53",
    "component": "SasView",
    "summary": "save points as file from graph loses precision",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "",
    "type": "defect"
}
@pkienzle pkienzle added this to the SasView 5.0.0 milestone Mar 30, 2019
@pkienzle pkienzle added Defect Bug or undesirable behaviour Incomplete Migration Minor Small job and removed Incomplete Migration labels Mar 30, 2019
@pkienzle
Copy link
Contributor Author

Trac update at 2017/09/19 14:51:10: pkienzle changed priority from "major" to "minor"

@pkienzle
Copy link
Contributor Author

Trac update at 2017/09/19 14:52:10: pkienzle commented:

The datainfo window shows 12 digits.

@butlerpd
Copy link
Member

Trac update at 2017/10/27 08:31:56: butler changed milestone from "SasView 4.2.0" to "SasView 5.0.0"

@RichardHeenan
Copy link
Contributor

Precision is still limited in 5.0 (note check with a theory, not experimental data, which may have been supplied with limited precision anyway).

Also "save points as a file" (from a plot) or "save as" from data tree, is in 5.0 not remembering the previous save to directory name, which would be nice.

rozyczko added a commit that referenced this issue Apr 25, 2019
Added last location memory to the dialog.
Github #1068
@rozyczko
Copy link
Member

Fixed precision - changed to %.15e as suggested.
Fixed corresponding , etc. marker locations
Fixed the 'memory' of the Save As... widget, so it remembers the last save location.

@RichardHeenan
Copy link
Contributor

Tested, issues fixed, thank you. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Minor Small job
Projects
None yet
Development

No branches or pull requests

4 participants