Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Q-range limits in Invariant Perspective has no effect on extrapolations #1609

Closed
smk78 opened this issue Jul 2, 2020 · 0 comments · Fixed by #1718
Closed

Changing Q-range limits in Invariant Perspective has no effect on extrapolations #1609

smk78 opened this issue Jul 2, 2020 · 0 comments · Fixed by #1718
Labels
Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Jul 2, 2020

In the Invariant tab of the Invariant Perspective you can change the Min and Max Q values. My working assumption is that this is so that you can exclude points at either end of the data prior to the extrapolations? However, if you try this you will find that the extrapolations always use the full range of the data (ie, if you had a dataset with 50 points and opted to extrapolate the low-Q end with 10 points it uses points 1 to 10. If you were to then set a Qmin to exclude the first 10 points you would expect that it would extrapolate on points 11 to 20. It doesn't, it still uses points 1 to 10. The same behaviour happens with the high-Q extrapolations). So, is this by design? If so, why are the Total Q Range boxes editable?

I notice these boxes are not editable in 4.x.

Also see #1608

@smk78 smk78 added Defect Bug or undesirable behaviour SasView Bug Fixing labels Jul 2, 2020
@smk78 smk78 added this to the SasView 5.0.4 milestone Jul 2, 2020
butlerpd added a commit that referenced this issue Jul 4, 2020
Adresses issue #1609. For now the box is read only though it would be
nice to eventually allow q limits to be set by the user.  This should be
part of ticket #1608.  Alternatnively it can become a separate feature
request that MUST be done first before #1608
@krzywon krzywon added this to Needs triage in Functionality Fest Dec 9, 2020
@krzywon krzywon moved this from Needs triage to Low priority in Functionality Fest Dec 9, 2020
@krzywon krzywon moved this from Low priority to Medium priority in Functionality Fest Dec 9, 2020
@wpotrzebowski wpotrzebowski added this to To do in SasViewHackathon-II via automation Jan 12, 2021
@wpotrzebowski wpotrzebowski added the Invariant Perspective Concerns invariant perspective label Jan 12, 2021
@krzywon krzywon moved this from To do to Review in SasViewHackathon-II Jan 13, 2021
SasViewHackathon-II automation moved this from Review to Done Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Invariant Perspective Concerns invariant perspective
Projects
Functionality Fest
Invariant issues
Development

Successfully merging a pull request may close this issue.

2 participants