Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the edge cases and added a beefy unit test. #1546 #1556

Merged
merged 1 commit into from
May 29, 2020
Merged

Fixed the edge cases and added a beefy unit test. #1546 #1556

merged 1 commit into from
May 29, 2020

Conversation

rozyczko
Copy link
Member

Ready for review.
Fixed edge cases and added unit tests.

@rozyczko rozyczko requested a review from m2cci-NMZ May 28, 2020 19:53
@wpotrzebowski wpotrzebowski linked an issue May 28, 2020 that may be closed by this pull request
Plotting an already plotted dataset causes the new plot to only show model #1546
Closed
m2cci-NMZ
m2cci-NMZ approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@m2cci-NMZ m2cci-NMZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty beefy unit test indeed!
All good

@m2cci-NMZ m2cci-NMZ merged commit 04f73b8 into ESS_GUI May 29, 2020
@rozyczko rozyczko deleted the ESS_GUI_1546_plot_woes branch May 29, 2020 08:00
@rozyczko rozyczko self-assigned this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m2cci-NMZ m2cci-NMZ m2cci-NMZ approved these changes

Assignees

@rozyczko rozyczko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotting an already plotted dataset causes the new plot to only show model
2 participants
@rozyczko @m2cci-NMZ