Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cancel button to the generic scattering calculator to cancel computations between each chunk of Q values. If the computation is cancelled the remainder of the Iq values are filled in with
NaN
. The ticket for this request suggests usingcalcthread.isquit()
, however the current code uses twisted.internet threads as opposed to the calcthread class in sasview. As far as I can tell there is no inbuilt way to detect an interruption in these threads, so a boolean flag is used. Upon cancelling the calculation the compute/cancel button becomes disabled until the current chunk of Q values have been computed.Currently the areas of the graph with
NaN
values are simply not updated, which can cause odd effects on the graph when cancelling a calculation. This is because thenumpy.nan_to_num
function in the current code is not correctly implemented, an issue fixed in #1888.fixes #1406