Pyinstaller part 2

[krzywon]

Description

This is a tweak to how pyinstaller creates packages. This maintains, for all OSes, the bundeled file structure that we used to have while continuing to use pyinstaller 6.

@klytje - Can you please test this on linux to see if the issue you reported is still present?

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

• There is nothing that needs documenting
• Documentation changes are in this PR
• There is an issue open for the documentation (link?)

Installers

• This will affect the installers
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • Ubuntu installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

• The introduced changes comply with SasView license (BSD 3-Clause)

[klytje]

sasview now succesfully opens, but crashes the moment I click the 'open file' pane (both in the GSC and Image Viewer; so I assume it's all of them) with the error:

[rozyczko]

On windows, this build seems to run fine.

[krzywon]

sasview now succesfully opens, but crashes the moment I click the 'open file' pane (both in the GSC and Image Viewer; so I assume it's all of them) with the error:

@klytje - Thanks for the report. Are you seeing this error with anything other programs? It looks like either a permissions or environment variable issue. I'll see what I can do about this from our end.

https://askubuntu.com/questions/1351607/gtk-warning-could-not-load-a-pixbuf-from-icon-theme
https://bbs.archlinux.org/viewtopic.php?id=261143

[klytje]

@krzywon I've never seen this error before (and I have both programs mentioned in that link installed). I am developing a GUI program myself relying on GTK, so I'd be very surprised if that's the issue. Anyway, I've now tested it on all of my systems.

The same issue is present on 2 separate Ubuntu 22.04 systems. On my Ubuntu 20.04 VM it works just fine. We need more test systems to know for sure if it's just my systems or if it could be 22.04 in general.

Errors unique to 22.04:

I'm not sure if it is related to your PR though - this is the first time I've tried running an installer from the release_6.0.0 branch without having it immediately crash on me.

[llimeht]

If the SasView windows installer is used to do a system-wide installation (which it can do and I think that's even the default), then it's buggy to be using {%USERPROFILE} in the installer config (.iss). The problem in the context of a system-wide installation is which single user will get the files in their profile, and what about other users? What happens with a central IT person insists on installing the software for the user, or SasView is installed on shared computers at a facility to be used by lots of different users?

There is an existing use of {%USERPROFILE} - but that's an empty directory that (I think) gets recreated at runtime if needed. (We should make sure that is true and then get rid of that entry in the .iss.)

To run sphinx at runtime in a user-writeable a location, some other creative solution is needed to correctly handle multi-user systems. Lazily copying the documentation across to the user profile on first start might work. Even better would be copying the documentation only once the user asks to edit it; rehoming the doc-base from the installer-provided files to the user-edited files only when needed would also address #2886.

Some work also needs to go into preventing data loss where the installer-provided documentation overwrites local edits to those files when upgrading versions. I think that would currently occur with the approach in this PR. (The above suggestions of lazily copying the files around could have similar issues depending on how they are implemented. Syncing is a hard problem.)