Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2732 fill in whats new boxes for release 6.0.0 #2880

Merged

Conversation

lucas-wilkins
Copy link
Contributor

@lucas-wilkins lucas-wilkins commented May 9, 2024

The What's New box is now looking pretty reasonable, and I've made improvements to its logic and appearance so it feels much nicer now.

Access it from What's New in Help if it doesn't automatically pop up.

I have not filled in anything for the plotting section or the GSC, perhaps @krzywon / @rozyczko, and @yunliu01 / @klytje would like to fill it in. Literally just need one two simple sentences and, preferably, at least one image. I can clean things up.

The last slide is for the changelist, which will be added during the final release prep.

Testing needed: As the resources backing the dialog will get packaged, we should check that it runs from the installers (should find out pretty quickly).

@lucas-wilkins lucas-wilkins linked an issue May 9, 2024 that may be closed by this pull request
@lucas-wilkins lucas-wilkins changed the base branch from main to release_6.0.0 May 9, 2024 23:32
@lucas-wilkins lucas-wilkins added the SasView 6.0.0 Required for 6.0.0 release label May 9, 2024
@lucas-wilkins lucas-wilkins added the Discuss At The Call Issues to be discussed at the fortnightly call label May 15, 2024
@krzywon
Copy link
Contributor

krzywon commented Jun 4, 2024

Comparing the beta release notes to the current contents of the What's New box, a few more items we could include:

@lucas-wilkins
Copy link
Contributor Author

I was planning on neatening things up tomorrow. I think the font size is to small, at least it seems so on my machine.

@krzywon - I think the images need a bit of reworking - I was planning on that tomorrow. Two things, if you let the renderer rescale the images it does a very bad job, and I want some nice fading out it doesn't look blocky. I'll sort it though, just letting you know my plans.

Do let me know if you plan to change the images again though, and I'll wait.

@krzywon
Copy link
Contributor

krzywon commented Jun 4, 2024

@lucas-wilkins - The latest images are better than the ones I replaced. Feel free to modify/replace/update them as you see fit. I'll wait for you to make your modifications before I push anything else to this branch.

@lucas-wilkins
Copy link
Contributor Author

@krzywon OK, done with it for now.

@klytje
Copy link
Contributor

klytje commented Jun 6, 2024

Comparing the beta release notes to the current contents of the What's New box, a few more items we could include:

Generic Scattering Calculator including the Debye speed-up, and Beta approximation (currently in 3.html) - @klytje or @yunliu01, could either of you handle this?

Section seems ok to me, do you think it should be more detailed?

@lucas-wilkins
Copy link
Contributor Author

Section seems ok to me, do you think it should be more detailed?

Personally, I think its about right ... but I did write it. Going for short, simple English, with as few technical details as possible. There are docs for details.

@krzywon
Copy link
Contributor

krzywon commented Jun 6, 2024

I just added the full changelist to the last page. I took it from the draft 6.0.0b1 release page. I think the changes made by @lucas-wilkins look good in their simplicity. In future iterations, we might want to link to the documentation.

Unless we want more pages, I think this is ready for review.

@lucas-wilkins lucas-wilkins marked this pull request as ready for review June 7, 2024 06:43
Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the last actions build for this branch on W10/x64 (https://github.com/SasView/sasview/actions/runs/9407271049). It installed and opened but threw an exception (see comment) from the What's New box.

@smk78
Copy link
Contributor

smk78 commented Jun 14, 2024

image

@lucas-wilkins
Copy link
Contributor Author

Tried the last actions build for this branch on W10/x64

Need to add that to the installer path, or an __init__.py file. Funny, was just looking at that very line.

@butlerpd
Copy link
Member

butlerpd commented Jul 2, 2024

check installer then merge

Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I just tried this build, https://github.com/SasView/sasview/actions/runs/9600919075, and it's still failing with the same error from the What's New when I start SasView.

installers/sasview.spec Outdated Show resolved Hide resolved
@butlerpd butlerpd removed the Discuss At The Call Issues to be discussed at the fortnightly call label Jul 16, 2024
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the installed version on Windows after the latest change by @lucas-wilkins and the What's New box now opens as expected. I think this is ready to go.

@smk78 - you were the one to see the original issue. If it's now working as expected for you, please feel free to merge.

@lucas-wilkins lucas-wilkins merged commit 628d599 into release_6.0.0 Jul 16, 2024
28 checks passed
@lucas-wilkins lucas-wilkins deleted the 2732-fill-in-whats-new-boxes-for-release-600-1 branch July 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill in What's New boxes for release 6.0.0
5 participants