Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX code signing debug #2884

Merged
merged 8 commits into from
Jun 18, 2024
Merged

OSX code signing debug #2884

merged 8 commits into from
Jun 18, 2024

Conversation

wpotrzebowski
Copy link
Contributor

Description

Code signing on Mac is failing and needs debugging

Fixes # (issue/issues)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon
Copy link
Contributor

krzywon commented Jun 18, 2024

The Mac installer failure was due to a 'Resource busy' error, not a code signing error. We could rerun that step to be sure everything is working, but the parallel pull request runner succeeded. I think this looks ready to go. Great work, @wpotrzebowski and @timsnow!

@wpotrzebowski
Copy link
Contributor Author

@krzywon yes, I've just tested the installer and indeed it works! (I need to do some clean-ups with GH actions secrets but we should be back on track now)

@lucas-wilkins
Copy link
Contributor

Wohooo! Nice work guys!

@krzywon
Copy link
Contributor

krzywon commented Jun 18, 2024

@wpotrzebowski, I know you would like to do some cleanup, but I would like to have the beta out today and this solves the last two outstanding issues.

I'm going to merge this and ask that you do any cleanup work in a different branch.

@krzywon krzywon marked this pull request as ready for review June 18, 2024 18:50
@krzywon krzywon merged commit 8e146c5 into release_6.0.0 Jun 18, 2024
29 checks passed
@krzywon krzywon deleted the osx-signing-debugging branch June 18, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants