no ticket: remove unnecessary sleep #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkienzle
changed the title
There was a problem hiding this comment.
Tested extenisvely on Mac OSX 10.11 bare metal and Win7 VM and haven't experienced any problems.
We may want to test it on bare metal Windows before merging. @rozyczko and/or @RichardHeenan : can you please checkout ticket-854 branch, run sasview can check if models compute?
|
I tested this on Win10 and there doesn't seem to be any issue. I ran a few individual data set fits, ran a constrained fit, saved a constrained fit project, and then reloaded it without seeing any errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request needs to be tested variety of platforms for a variety of models. In particular, should be tested on mac and windows with and without OpenCL.
Requires ticket-851 pull request is applied to sasmodels.
Try to stress the system by hitting the calc button while fitting, the fit button while calculation, saving and loading complicated models, etc.
Should wait for the beginning of the release cycle: having the sleep() in the code shouldn't break anything, but removing it may exposes errors if the problem was not due to multiple threads in the calculator at the same time.