Configure filesystem paths from the command line #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
force-pushed
the
eliza/file-path-args
branch
from
c3d2265
to
3c72445
Compare
Currently, all paths used by the server are hard-coded to paths in the directory where the server source code is located. On Unix systems, it's preferable to store state, configuration, and log files in different directories. Therefore, this commit adds the following new command-line arguments to configure these paths: - `--state-dir`: configures the directory where the database and uploaded image files are stored. - `--config-path`: configures the path to the config file. - `--log-path`: configures the path to the directory where log files will be written. - `--lock-path`: configures the path to the directory where the server will store its PID lock file. If these command-line arguments are not provided, the server behaves identically to the way it does today.
hawkw
force-pushed
the
eliza/file-path-args
branch
from
3c72445
to
4f838bb
Compare
hawkw
added a commit
to hawkw/vu-server-flake
that referenced
this pull request
Feb 13, 2024
looks like SasaKaranovic/VU-Server#24 is probably not going to happen, so let's just switch back to upstream and symlink the files we need into the runtime dir. I don't like this, but it's fine...
|
This PR should be addressed by the #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all paths used by the server are hard-coded to paths in the directory where the server source code is located. On Unix systems, it's preferable to store state, configuration, and log files in different directories. Therefore, this commit adds the following new command-line arguments to configure these paths:
--state-dir: configures the directory where the database and uploaded image files are stored.--config-path: configures the path to the config file.--log-path: configures the path to the directory where log files will be written.--lock-path: configures the path to the directory where the server will store its PID lock file.If these command-line arguments are not provided, the server behaves identically to the way it does today.
Fixes #20