Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporating review comments #6

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Incorporating review comments #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ version = "1.0.0"
description = "Detect File upload requests and scan them to find related vulnerabilities"

zapAddOn {
addOnName.set("File upload Scan Rule")
addOnName.set("FileUpload")
addOnStatus.set(AddOnStatus.ALPHA)
zapVersion.set("2.11.0")
manifest {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/sasanlabs/fileupload/ui/FileUploadOptionsPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ public void validateParam(Object optionParams) throws Exception {

@Override
public String getHelpIndex() {
return "ui.dialog.options.fileupload";
return "fileupload";
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/javahelp/org/sasanlabs/fileupload/resources/help/contents/fileupload.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <H3>Explanation about Options Panel</H3>
only the file name is changed. For handling this type of configuration,
options panel has <B>Static Location Configuration</B> where
static URL is added into URI Regex field. URI Regex field also supports the dynamic file name
by <B>${fileName}</B>. parameter, for e.g. http://<baseurl>/${fileName}
by <B>${fileName}</B>. parameter, for e.g. http://{baseurl}/${fileName}
</LI>
<LI>
In some applications the URL to retrieve the uploaded file is present in the file upload request's response.
Expand Down
4 changes: 2 additions & 2 deletions src/main/javahelp/org/sasanlabs/fileupload/resources/help/helpset.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
PUBLIC "-//Sun Microsystems Inc.//DTD JavaHelp HelpSet Version 2.0//EN"
"http://java.sun.com/products/javahelp/helpset_2_0.dtd">
<helpset version="2.0" xml:lang="en-GB">
<title>Simple Example Add-On</title>
<title>FileUpload Add-On</title>

<maps>
<homeID>top</homeID>
<homeID>fileupload</homeID>
<mapref location="map.jhm"/>
</maps>

Expand Down
2 changes: 1 addition & 1 deletion src/main/javahelp/org/sasanlabs/fileupload/resources/help/map.jhm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"http://java.sun.com/products/javahelp/map_1_0.dtd">

<map version="1.0">
<mapID target="ui.dialog.options.fileupload" url="contents/fileupload.html" />
<mapID target="fileupload" url="contents/fileupload.html" />
</map>