Strict object check in environment.load

SassDoc · Feb 4, 2015 · 494997c · 494997c
1 parent 52a4a6f
commit 494997c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/environment.js b/src/environment.js
@@ -52,11 +52,11 @@ export default class Environment extends EventEmitter {
       return this.loadDefaultFile();
     }
 
-    if (typeof config === 'string') {
+    if (is.string(config)) {
       return this.loadFile(config);
     }
 
-    if (typeof config === 'object') {
+    if (is.plainObject(config)) {
       return this.loadObject(config);
     }
 

diff --git a/test/env/environment.test.js b/test/env/environment.test.js
@@ -46,15 +46,20 @@ describe('#environment', function () {
    * Passed in wrong type config file.
    */
   describe('#config-fail', function () {
-    var spy = sinon.spy();
+    var spy;
 
     beforeEach(function () {
+      spy = sinon.spy();
       env.on('error', spy);
-      env.load(123); // @TOO [] pass
-      env.postProcess();
     });
 
-    it('should error if config is of a wrong format', function () {
+    it('should error if config is a number', function () {
+      env.load(123);
+      assert.ok(spy.called);
+    });
+
+    it('should error if config is an array', function () {
+      env.load([]);
       assert.ok(spy.called);
     });
   });