Mixin with a property that's the same name causes an incorrect "Requires" output #359

Closed
cshawaus opened this Issue Feb 5, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@cshawaus

cshawaus commented Feb 5, 2015

I couldn't find anything on this one, essentially what's happening is the following for example.

@mixin position($position) {
  position: $position;
}

When SassDoc parses this it sees the property position as a requirement instead of looking ahead first and determining the type of execution thus it assumes position requires position even though it doesn't, to get around this for the time being I can prefix the mixin which doesn't bother me too much as seen below.

@mixin t-position($position) {
  position: $position;
}

SassDoc version: 2.0.3
NPM version: 1.4.28

@cshawaus cshawaus changed the title from Mixin with a property that's the same name causes an incorrect `Requires` output to Mixin with a property that's the same name causes an incorrect "Requires" output Feb 5, 2015

@HugoGiraudel

This comment has been minimized.

Show comment
Hide comment
@HugoGiraudel

HugoGiraudel Feb 5, 2015

Member

There is some weird shit going on here. @SassDoc/owners?

Member

HugoGiraudel commented Feb 5, 2015

There is some weird shit going on here. @SassDoc/owners?

@HugoGiraudel HugoGiraudel added the Bug label Feb 5, 2015

FWeinb added a commit that referenced this issue Feb 8, 2015

@FWeinb FWeinb referenced this issue Feb 8, 2015

Merged

Fix #359 #361

@FWeinb

This comment has been minimized.

Show comment
Hide comment
@FWeinb

FWeinb Feb 8, 2015

Member

Fixed on develop. This needs a backport to master.

Member

FWeinb commented Feb 8, 2015

Fixed on develop. This needs a backport to master.

@FWeinb FWeinb closed this in 8d378ae Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment