Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom annotations with async resolve fns do not work. #517

Closed
jgerigmeyer opened this issue Nov 17, 2017 · 1 comment
Closed

Custom annotations with async resolve fns do not work. #517

jgerigmeyer opened this issue Nov 17, 2017 · 1 comment

Comments

@jgerigmeyer
Copy link
Contributor

There are many cases where a custom theme annotation might want to do something asynchronously in a resolve fn. Currently, SassDoc does not wait for the annotations to finish resolving before calling the custom theme fn. It'd be great if SassDoc would allow for resolve fns that return a promise, and wait for them before proceeding. Proposed PR forthcoming.
@jgerigmeyer jgerigmeyer mentioned this issue Nov 17, 2017
Merged
@jgerigmeyer
Copy link
Contributor Author

PR submitted: #518.

@jgerigmeyer jgerigmeyer mentioned this issue Nov 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgerigmeyer