New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom annotations with async resolve fns do not work. #517

Closed
jgerigmeyer opened this Issue Nov 17, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jgerigmeyer
Contributor

jgerigmeyer commented Nov 17, 2017

There are many cases where a custom theme annotation might want to do something asynchronously in a resolve fn. Currently, SassDoc does not wait for the annotations to finish resolving before calling the custom theme fn. It'd be great if SassDoc would allow for resolve fns that return a promise, and wait for them before proceeding. Proposed PR forthcoming.

@jgerigmeyer

This comment has been minimized.

Contributor

jgerigmeyer commented Nov 17, 2017

PR submitted: #518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment