Consider adding code coverage

[pascalduez]

Just trying out.

Provides some interesting insights on how the codebase is tested.
Travis reports directly to https://coveralls.io
Coveralls add a comment on PRs to report coverage changes. See SassDoc/sass-convert#8

What do you think, useful or not ?

[coveralls]

Changes Unknown when pulling 2fd6d28 on coverage into * on develop*.

[pascalduez]

[KittyGiraudel]

Okay on core repository only.

[valeriangalliat]

We maybe need to refactore CLI tests in makefile to be executed through Node so we can test CLI coverage?

[pascalduez]

We maybe need to refactore CLI tests in makefile to be executed through Node so we can test CLI coverage?

That's what I thought, but does not seem to really influence the result ?

There is a minor issue:
Coveralls fetch files from Github to display them, but dist is not git tracked.
https://coveralls.io/r/SassDoc/sassdoc
Actually we don't really need coveralls, except if we want a nice badge and make the results public.
Istanbul provides html reports: make view-cover.

[valeriangalliat]

view-cover should depend on cover (empty result if make cover was not manually executed before).

[coveralls]

Changes Unknown when pulling b8073e8 on coverage into * on develop*.

[coveralls]

Changes Unknown when pulling ac24600 on coverage into * on develop*.

[coveralls]

Changes Unknown when pulling 9dcb25e on coverage into * on develop*.

[KittyGiraudel]

When is this going to be merged?

[pascalduez]

Depends whether we get a consensus from @SassDoc/owners ?

I personally like it, it's a good way to motivates us to write more tests, and also discover hidden issues.
The coveralls integration is not mandatory.

[valeriangalliat]

👍

[FWeinb]

👍

[coveralls]

Changes Unknown when pulling dd76770 on coverage into * on develop*.

[pascalduez]

Most recent status.
Would be interesting to add tests for Environment.

[KittyGiraudel]

Shall we open an issue about increasing test coverage? 80% is pretty neat, but I'd like us to bump 90-95% if it's doable.

[pascalduez]

We won't reach 100% anyway, due to the ES(6|2015) transpilation, there's some snippets from 6to5 that aren't called, and would make no sense for us to test them.
But for sure, we can improve things.