Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to babel-preset-env #486

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Switch to babel-preset-env #486

merged 1 commit into from
Mar 7, 2017

Conversation

pascalduez
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 6, 2017 •
edited

Coverage Status

Coverage remained the same at 91.854% when pulling 284148f on feature/babel-preset-env into 9fd6b86 on master.

valeriangalliat
valeriangalliat approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@valeriangalliat valeriangalliat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about this, looks neat!

@pascalduez
Copy link
Member Author

I've been a bit pinch in explanations :)

Briefly:

  • The Babel maintainers are promoting this preset in replacement of any other one.
  • By default it does the extact same thing as the latest one.
  • With the given settings I guess our compiled code is unchanged.
  • I looks way smarter.

@KittyGiraudel
Copy link
Member

Sweet!

@pascalduez pascalduez merged commit 68b6fef into master Mar 7, 2017
@pascalduez pascalduez deleted the feature/babel-preset-env branch March 7, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriangalliat valeriangalliat valeriangalliat approved these changes

@KittyGiraudel KittyGiraudel Awaiting requested review from KittyGiraudel

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pascalduez @coveralls @KittyGiraudel @valeriangalliat