Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some group maps are invisible on multimap view #3071

Closed
benhammondmusic opened this issue Mar 27, 2024 · 0 comments · Fixed by #3348
Closed

Some group maps are invisible on multimap view #3071

benhammondmusic opened this issue Mar 27, 2024 · 0 comments · Fixed by #3348
Labels
bug Something isn't working frontend help-wanted great first issue or place to start for our open source community members 👕 T-Shirt SM vega

Comments

@benhammondmusic
Copy link
Collaborator

Describe the bug
Some race maps don't appear, but can be hovered and show a value

To Reproduce
Steps to reproduce the behavior:

  1. http://localhost:3000/exploredata?mls=1.hiv-3.24510&mlp=disparity&dt1=hiv_prevalence&group1=Hisp%7ELat&demo=race_and_ethnicity&multiple-maps=true
  2. observe "Asian" isn't visible, but can be hovered and shows a value

Related to #2711 possibly
@benhammondmusic benhammondmusic added bug Something isn't working frontend vega help-wanted great first issue or place to start for our open source community members 👕 T-Shirt SM labels Mar 27, 2024
@benhammondmusic benhammondmusic mentioned this issue Mar 27, 2024
Merged
@benhammondmusic benhammondmusic mentioned this issue May 30, 2024
Merged
benhammondmusic added a commit that referenced this issue May 30, 2024
@benhammondmusic
Fixes missing multimap bug (#3348)
922f2a1 
# Description and Motivation
<!--- bulleted, high level items. use keywords (eg "closes #144" or
"fixes #4323") -->

- Fixes #3071 
- the `fieldRange` prop was getting passed through, and that function
was only filtering out `NaN` values but not `null` values. This was
causing the weirdness (i think)
- adds unit test coverage for this edge case
- memoizes the fieldRange call rather than invoking it on every render

## Has this been tested? How?

- adds unit test
- tests pass
- manually confirmed on various reports, including one that includes a
real zero value which gets properly colored

## Screenshots (if appropriate)

<img width="921" alt="Screenshot 2024-05-30 at 11 39 02 AM"
src="https://github.com/SatcherInstitute/health-equity-tracker/assets/41567007/d4da2ca5-920a-42e8-867f-a4b970952e4c">
<img width="921" alt="Screenshot 2024-05-30 at 11 39 15 AM"
src="https://github.com/SatcherInstitute/health-equity-tracker/assets/41567007/76f30aca-e5e5-4b8d-8a8f-d5ba94d2877f">


## Types of changes

(leave all that apply)

- Bug fix
- Refactor / chore

## New frontend preview link is below in the Netlify comment 😎
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend help-wanted great first issue or place to start for our open source community members 👕 T-Shirt SM vega
Projects
HET Board
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes missing multimap bug benhammondmusic/health-equity-tracker
1 participant
@benhammondmusic