Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Multimap Modal Close and Legend #2159

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Apr 27, 2023

Description

  • replaces Close in bottom right corner with X in top right corner, mirroring the close button layout in the downloads section and typical modal behavior
  • uses single column legend for tiny screens and two row horizontal layout for wider screens, adjusts spacing, legend is always on its own row

Motivation and Context

closes #2157

Has this been tested? How?

manually.

Screenshots (if appropriate):

Screen Shot 2023-04-26 at 11 01 04 PM

Screen Shot 2023-04-26 at 11 01 14 PM

Screen Shot 2023-04-26 at 11 01 22 PM

Screen Shot 2023-04-26 at 11 01 31 PM

Screen Shot 2023-04-26 at 11 01 41 PM

Screen Shot 2023-04-26 at 11 08 00 PM

Types of changes

  • Bug fix
  • New content or feature

Post-merge TODO

I have inspected frontend changes and/or run affected data pipelines:

  • on DEV
  • on PROD

Any target user persona(s)?

Preview link below in Netlify comment 😎

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 08c4bcb
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/644a02b493823e0008728003
😎 Deploy Preview https://deploy-preview-2159--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@benhammondmusic benhammondmusic self-assigned this Apr 27, 2023
@benhammondmusic benhammondmusic marked this pull request as ready for review April 27, 2023 05:08
@benhammondmusic benhammondmusic merged commit 8f4fcdd into SatcherInstitute:main Apr 27, 2023
9 checks passed
@benhammondmusic benhammondmusic deleted the close branch April 27, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve Multimap Modal
2 participants