Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up multimap and more #2162

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Apr 27, 2023

Description

  • removes dead population card code
  • better props for map cards
  • use <TerritoryCircles> on <UnknownsMapCard>
  • cleanup multimap footer; make text smaller
  • swap all footers so the NH note comes first, and then sources is always there in line with card action buttons
  • fix issue with legend summary text getting chopped off
  • fix wording issue with <UnknownsAlert> placement

Motivation and Context

lots of little things looking goofy

Has this been tested? How?

manually

Screenshots (if appropriate):

Screen Shot 2023-04-27 at 9 07 48 AM

Screen Shot 2023-04-27 at 9 08 14 AM

Screen Shot 2023-04-27 at 9 08 20 AM

Screen Shot 2023-04-27 at 9 08 31 AM

Screen Shot 2023-04-27 at 9 08 38 AM

Screen Shot 2023-04-27 at 9 09 59 AM

Screen Shot 2023-04-27 at 9 10 31 AM

Screen Shot 2023-04-27 at 9 10 39 AM

Screen Shot 2023-04-27 at 9 10 49 AM

Screen Shot 2023-04-27 at 9 11 00 AM

Types of changes

  • Bug fix
  • New content or feature
  • Refactor / chore

Post-merge TODO

I have inspected frontend changes and/or run affected data pipelines:

  • on DEV
  • on PROD

Any target user persona(s)?

Preview link below in Netlify comment 😎

…oter on multi; fix legend bug chopping end of summary text; rm pop card code; better props for maps
@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 94f8ad1
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/644aaf93cd7889000804d179
😎 Deploy Preview https://deploy-preview-2162--health-equity-tracker.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@benhammondmusic benhammondmusic self-assigned this Apr 27, 2023
@benhammondmusic benhammondmusic marked this pull request as ready for review April 27, 2023 17:44
Copy link
Collaborator

@eriwarr eriwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🏿

@benhammondmusic benhammondmusic merged commit 3f2145a into SatcherInstitute:main Apr 27, 2023
9 checks passed
@benhammondmusic benhammondmusic deleted the multi-footer branch April 27, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants