fix(sidebar): user status reactivity bug (#4939)

* fix(sidebar): user status reactivity bug * fix(profile): maintain vue observer
Satellite-im · Sep 20, 2022 · 26eb842 · 26eb842
1 parent d2690f3
commit 26eb842
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/components/views/navigation/sidebar/status/Status.html b/components/views/navigation/sidebar/status/Status.html
@@ -1,4 +1,4 @@
-<div id="status" v-show="!!profile">
+<div id="status">
   <UiUserState :user="profile" />
   <div class="user-info" v-tooltip.top="$t('controls.copy_id')" @click="copyId">
     <TypographyTitle data-cy="user-name" :text="profile.name" :size="6" />

diff --git a/components/views/navigation/sidebar/status/Status.vue b/components/views/navigation/sidebar/status/Status.vue
@@ -3,11 +3,12 @@
 <script lang="ts">
 import Vue from 'vue'
 import iridium from '~/libraries/Iridium/IridiumManager'
-import { User } from '~/libraries/Iridium/users/types'
 
 export default Vue.extend({
   data() {
-    return { status: 'online', profile: iridium.profile.state }
+    return {
+      profile: iridium.profile.state,
+    }
   },
   methods: {
     copyId() {

diff --git a/components/views/settings/pages/profile/Profile.html b/components/views/settings/pages/profile/Profile.html
@@ -131,7 +131,7 @@
                     <edit-icon size="1x" />
                   </InteractablesInput>
                 </form>
-                <div v-if="profile && !!profile.status" class="status">
+                <div class="status">
                   <TypographyText as="h6">
                     {{ $t('pages.settings.profile.current_status') }}
                   </TypographyText>

diff --git a/libraries/Iridium/profile/ProfileManager.ts b/libraries/Iridium/profile/ProfileManager.ts
@@ -50,8 +50,6 @@ export default class IridiumProfile extends Emitter {
         return
       }
       logger.info('iridium/profile', 'profile state changed', state)
-      this.state = state.value?.profile
-      this.setUser()
       this.emit('changed', state)
     }
   }
@@ -77,10 +75,9 @@ export default class IridiumProfile extends Emitter {
 
   async updateUser(details: Partial<User>) {
     logger.info('iridium/profile', 'updating user', { details })
-    this.state = {
-      ...this.state,
-      ...details,
-    } as User
+    for await (const [key, value] of Object.entries(details)) {
+      this.state[key] = value
+    }
     await this.set('/', this.state)
     if (!this.state || !iridium.id) return
     // tell our peers via user announce