feat(sounds): combine deafen/undeafen into one toggle control (#3218)

Satellite-im · May 23, 2022 · e4be338 · e4be338
1 parent df6a013
commit e4be338
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/components/views/settings/pages/audio/sounds/Sounds.html b/components/views/settings/pages/audio/sounds/Sounds.html
@@ -15,19 +15,14 @@
   />
   <SettingsPagesAudioSoundsItem
     :value="sound(Sounds.MUTE)"
-    @toggle="toggleSound(Sounds.MUTE, $event)"
+    @toggle="toggleSounds([Sounds.MUTE, Sounds.UNMUTE], $event)"
     :title="$t('pages.settings.notifications.sounds.mute')"
   />
   <SettingsPagesAudioSoundsItem
     :value="sound(Sounds.DEAFEN)"
-    @toggle="toggleSound(Sounds.DEAFEN, $event)"
+    @toggle="toggleSounds([Sounds.DEAFEN, Sounds.UNDEAFEN], $event)"
     :title="$t('pages.settings.notifications.sounds.deafen')"
   />
-  <SettingsPagesAudioSoundsItem
-    :value="sound(Sounds.UNDEAFEN)"
-    @toggle="toggleSound(Sounds.UNDEAFEN, $event)"
-    :title="$t('pages.settings.notifications.sounds.undeafen')"
-  />
   <SettingsPagesAudioSoundsItem
     :value="sound(Sounds.UPLOAD)"
     @toggle="toggleSound(Sounds.UPLOAD, $event)"

diff --git a/components/views/settings/pages/audio/sounds/Sounds.vue b/components/views/settings/pages/audio/sounds/Sounds.vue
@@ -24,6 +24,11 @@ export default Vue.extend({
     toggleSound(key: Sounds, value: boolean) {
       this.$store.commit('sounds/set', { key, value })
     },
+    toggleSounds(keys: Sounds[], value: boolean) {
+      for (const key of keys) {
+        this.$store.commit('sounds/set', { key, value })
+      }
+    },
   },
 })
 </script>