-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chatbar): **markdown** in chatbar #1040
Conversation
emoji.movspoilers.movOnly 2 issue I noticed going through was Emoji is showing up tiny in the chatbar and when you select an emoji the menu will move to the opposite side of the screen and spoilers was not working correctly for me either (verified this problem only happens on my local and not dev) otherwise all good |
For the emoji i'll check. What do you mean by "tiny"? How should they appear? I see the spoilers are working correctly in the chatbar, they do not work correctly once you send the message because that part is still a WIP. |
I think the emojis looking too small was just me so you can just scratch that lol and noted about the spoilers 👍 |
thanks for testing @phillsatellite 🔨 @molimauro thanks for clarifying, is there anything else that is a WIP? |
Great!! Thanks :) |
This PR was meant to refactor the chatbar, the sent messages must be parsed according the new markdown rules created. |
@molimauro yes, both Phil and I checked the additional comments, but there was nothing there regarding the spoilers being a WIP, thats why im asking to double check 😂 |
@stavares843 yeah sorry, i should have been more specific. Spoilers and underlines are "special" md rules i have added. They are parsed correctly only in the chatbar and not when sent :) |
360a9b6
to
7eae0a1
Compare
@phillsatellite i should've fixed the enhancer problem :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, there are a couple minor things you could change if you wanted, but up to you
neat, thanks for checking, just confirming 🎨 |
great job @stavares843, thanks 🎉 |
are you gonna address that layout change? 🔨 let me know if you need more details also, conflict 🔨 |
yes, i'm doing it! I asked to Liz because i had to reduce the padding but kept the 48px height. I'll resolve also other minor fixes i discovered (like adding a max-height on the chat, otherwise if you keep adding a lot of paragraphs it's not very good) and then i rebase and push. Thanks!! |
327d668
to
f2f2e6d
Compare
Done, thanks guys!! |
What this PR does 📖
Chatbar markdown, chatbar rework, css bugfix, integrating old features, emoji fix. Focus input on reply, recipient switch, emoji selection.
Which issue(s) this PR fixes 🔨
AP-2
AP-196
AP-474
Special notes for reviewers 🗒️
Available markdown:
italics with * and _
bold **
underline __
escape command
code with single `
combined bold/italics ***
strikethrough ~~
autolinks <https://satellite.im>
url parsing
spoilers ||
Additional comments 🎤
Related to the chatbar, I’m going to open the following tickets: