Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profile): hide add friend button if already friends or self #1074

Merged
merged 1 commit into from
Jan 25, 2022
Merged

feat(profile): hide add friend button if already friends or self #1074

merged 1 commit into from
Jan 25, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jan 24, 2022 •
edited
Loading

What this PR does 📖
PROFILE MODAL

  • hide add friend button if already friends or self
  • send friend request on click of button
  • general refactoring + error cleanup
    • added toast types to tsconfig to eliminate need for tsignore
  • swapped for enums where possible
  • moved tab type declaration to proper directory

Which issue(s) this PR fixes 🔨
AP-509

Special notes for reviewers 🗒️

  • cannot fully test yet since users can only view profiles of friends. Added todo
  • regarding unique account identifiers.. is textilePubkey ok? or should I use address?

Additional comments 🎤

@josephmcg
feat(profile): hide add friend button if already friends or self
8fc473a 
* cannot test yet since users can only view profiles of friends
* general refactoring + error cleanup
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jan 24, 2022
@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label Jan 24, 2022
WanderingHogan
WanderingHogan reviewed Jan 25, 2022
View reviewed changes
store/friends/actions.ts
@@ -130,7 +130,7 @@ export default {
throw new Error(FriendsError.FRIEND_INFO_NOT_FOUND)
}

const friend: Friend = {
const friend: Omit<Friend, 'publicKey' | 'typingState'> = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is neat

@WanderingHogan WanderingHogan removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jan 25, 2022
@stavares843 stavares843 changed the title feat(profile): hide add friend button if already friends or self AP-509 feat(profile): hide add friend button if already friends or self Jan 25, 2022
@stavares843 stavares843 merged commit 294a9ef into dev Jan 25, 2022
@stavares843 stavares843 deleted the AP509 branch January 25, 2022 17:49
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@Jekrimo Jekrimo Jekrimo approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josephmcg @WanderingHogan @Jekrimo @phillsatellite @stavares843