-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(groupChatManager): create a groupChat manager to create separate collections on a thread #1291
Conversation
/rebase |
a3a5c1b
to
5e9377d
Compare
do we know why appears the errors.textile.friend_not_found from Phil's screenshot? I see that added here can we fix the warning when it finishes compiling locally? atm we have zero compiling warnings after compiling |
✔️ Yeeeehaw, deploy preview is ready! 🔨 Explore the source changes: fee27c5 🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6205176d3dd85a0008742882 😎 Browse the preview: https://deploy-preview-1291--adoring-edison-dbcef8.netlify.app |
is possible to get the textile error that phil mentioned above fixed as well? 🔨 |
I'm tryin to recreate it and can't get the error, is it showing for anyone else? |
Hey Jeff! Sorry didn't notice earlier I got that error from trying to react to a message, which you said above isnt working yet 👍 |
thanks for testing @phillsatellite |
Awesome! That's great news, perfect! |
if ( | ||
RegExp(this.$Config.regex.uuidv4).test(this.recipient.textilePubkey) | ||
) { | ||
this.$store.dispatch('textile/sendGroupMessage', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about dumping the if/else and doing something like
// Check if the message is a group or a direct message
const messageType = RegExp(this.$Config.regex.uuidv4).test(
this.recipient.textilePubkey,
)
? 'sendGroupMessage'
: 'sendTextMessage'
this.$store.dispatch(`textile/${messageType}`, {
to: this.recipient.textilePubkey,
text: value,
})
```
@@ -4,6 +4,7 @@ import Vue, { PropType } from 'vue' | |||
import { mapState } from 'vuex' | |||
|
|||
import { MessageGroup } from '~/types/messaging' | |||
import { Message } from '~/types/textile/mailbox' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this getting ready for something in the future, or leftover
What this PR does 📖
create a groupChat manager to create separate collections on a thread, allow sending messages, listening to the collection for changes, eventEmitters for testing I presume
Which issue(s) this PR fixes 🔨
AP-660
Special notes for reviewers 🗒️
EDIT: Testable now. 3 Groups are hardcoded for testing. Users will show as unknown unless it's your user. There are also other bug's and features missing currently. Most have been identified in AP-732 -> AP-744