Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): clicking on user avatar shows profile modal #1298

Merged
merged 7 commits into from
Feb 12, 2022
Merged

feat(ui): clicking on user avatar shows profile modal #1298

merged 7 commits into from
Feb 12, 2022

Conversation

vimercati-samir
Copy link
Contributor

What this PR does πŸ“–
clicking on the user status avatar or user quickProfile avatar shows profile modal

Which issue(s) this PR fixes πŸ”¨
AP-508

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 3, 2022
@molimauro molimauro added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Feb 3, 2022
@stavares843 stavares843 removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 4, 2022
@molimauro
Copy link
Contributor

There's also this bug:

rec.mov

@vimercati-samir
Copy link
Contributor Author

There's also this bug:

rec.mov

is this really a bug or the intended behavior? now the quick profile modal is close whenever a click happen outside his boundaries

@molimauro
Copy link
Contributor

There's also this bug:
rec.mov

is this really a bug or the intended behavior? now the quick profile modal is close whenever a click happen outside his boundaries

ok the click outside but if i click on another user image it should show the corresponding quick profile

@vimercati-samir
Copy link
Contributor Author

There's also this bug:
rec.mov

is this really a bug or the intended behavior? now the quick profile modal is close whenever a click happen outside his boundaries

ok the click outside but if i click on another user image it should show the corresponding quick profile

fixed in commit c69ad2b

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 4, 2022
@stavares843 stavares843 added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 7, 2022
@phillsatellite
Copy link
Contributor

Just to verify, User is supposed to be able to click anywhere on the side and have the quick profile pop up?

clicking.mov

@phillsatellite phillsatellite added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Feb 7, 2022
@stavares843
Copy link
Member

what @phillsatellite added should be addressed

@vimercati-samir
Copy link
Contributor Author

what @phillsatellite added should be addressed

fixed accordingly in commit 41b10b0

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 8, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Feb 9, 2022
stavares843
stavares843 requested changes Feb 9, 2022
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-02-09, às 17 08 59

left side is dev
right side is this branch

did we changed the close icon on this branch? is lacking padding on this branch

both images are on a iPhone 12 pro on browser

@stavares843
Copy link
Member

added minor comment

missing fixing conflict πŸ”¨

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed QA tested One QA Person has tested - Needs QA Lead review still labels Feb 9, 2022
@vimercati-samir
Copy link
Contributor Author

Captura de ecrã 2022-02-09, às 17 08 59

left side is dev right side is this branch

did we changed the close icon on this branch? is lacking padding on this branch

both images are on a iPhone 12 pro on browser

Nope I didn't change any styles regarding the quick profile, on my end it looks just like the one in dev

@github-actions github-actions bot removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Feb 11, 2022
@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022 •
edited
Loading

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: 08cd7fc

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6206f6a81a70310007c3f8dd

😎 Browse the preview: https://deploy-preview-1298--adoring-edison-dbcef8.netlify.app

@stavares843
Copy link
Member

2 minor things

Gravacao.do.ecra.2022-02-11.as.23.28.41.mov

the avatar is clickable but shows a pointy arrow instead of the clickable hovering

also, when you go to the user profile, you see the quick profile still open underneath, but when you close the user profile, the quick profile also closes - so should that not be open underneath when accessing the user profile?

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Feb 11, 2022
@WanderingHogan
Copy link
Contributor

@stavares843 update made

@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 11, 2022
@stavares843
Copy link
Member

neat πŸŽ‰

@stavares843 stavares843 changed the title feat(ui): clicking on the user status avatar or user quickProfile avatar shows profile modal feat(ui): clicking on user avatar shows profile modal Feb 12, 2022
@stavares843 stavares843 merged commit 3544feb into dev Feb 12, 2022
@stavares843 stavares843 deleted the avatar-click-profile-modal branch February 12, 2022 02:36
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@josephmcg josephmcg josephmcg approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vimercati-samir @molimauro @phillsatellite @stavares843 @WanderingHogan @josephmcg