Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(friends): display outgoing friend requests after send #1348

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Feb 7, 2022

What this PR does πŸ“–

  • show list of outgoing friend requests

Which issue(s) this PR fixes πŸ”¨
AP-702

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 7, 2022
@stavares843
Copy link
Member

Captura de ecrã 2022-02-07, às 16 33 38

Captura de ecrã 2022-02-07, às 16 38 35

neat πŸ’₯

@stavares843
Copy link
Member

Captura de ecrã 2022-02-07, às 16 39 11

clicking on the cancel request, doesn't cancel the request, is that to be addressed on a separate PR?

@stavares843
Copy link
Member

Captura de ecrã 2022-02-07, às 16 39 11

also, what's the order this is added? I added asdadada first, then asher, then hogan but they are not added on that order or alphabetically

@stavares843 stavares843 added temporary blocked checking something QA Lead is checking something. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 7, 2022
@stavares843
Copy link
Member

cancel request - AP-703

@stavares843
Copy link
Member

stavares843 commented Feb 7, 2022

added ticket to improve the order - AP-713

@stavares843 stavares843 removed the temporary blocked checking something QA Lead is checking something. label Feb 7, 2022
@stavares843 stavares843 changed the title feat(friends): display outgoing friend requests after send AP-702 feat(friends): display outgoing friend requests after send Feb 7, 2022
@stavares843 stavares843 merged commit c65bea5 into dev Feb 7, 2022
@stavares843 stavares843 deleted the outgoingRequests branch February 7, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants