fix(media): fix media full screen in servers chat and some aside bar … #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Explore the source changes: 1f0871f |
InfamousVague
requested changes
Sep 14, 2021
| @@ -88,7 +88,7 @@ | |||
| position: fixed; | |||
| right: 0px; | |||
| top: 0px; | |||
| z-index: 2; | |||
| z-index: 999; | |||
There was a problem hiding this comment.
Let's avoid using this, instead please determine what the z-index we need is, and use @base-z-index + required index
IvanM3x
force-pushed
the
fix_direct_media_fullscreen
branch
from
d94d8f8
to
1f0871f
Compare
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: SA-159 + SA-177