feat(settings): add clearLocalStorage action #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
phillsatellite
approved these changes
Feb 9, 2022
phillsatellite
added
the
QA tested
molimauro
approved these changes
Feb 9, 2022
WanderingHogan
approved these changes
Feb 9, 2022
WanderingHogan
removed
the
Missing Dev Review
|
@AlexZakablukov can you add a window refresh or something to reload the page after they click the clear local storage button |
phillsatellite
added
Changes Requested
stavares843
reviewed
Feb 9, 2022
| @@ -473,6 +474,9 @@ export default { | |||
| mailbox_manager_not_found: 'Mailbox manager not found', | |||
| mailbox_manager_not_initialized: 'Mailbox manager not initialized', | |||
| }, | |||
| storage: { | |||
| database_not_cleared: 'Could not clear database', | |||
There was a problem hiding this comment.
what would trigger this error btw? I tried clear storage and then clear storage again but always shows ''Local storage cleared successfully''
|
will add a ticket for the reload |
github-actions
bot
removed
the
Changes Requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
implement clear localstorage and indexed db feature by clicking on "clear local storage" button in settings
Which issue(s) this PR fixes 🔨
AP-700
Special notes for reviewers 🗒️
Additional comments 🎤