Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): 100% code coverage for Commands.test.ts #1455

Merged
merged 8 commits into from
Feb 14, 2022
Merged

feat(jest): 100% code coverage for Commands.test.ts #1455

merged 8 commits into from
Feb 14, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Feb 11, 2022

What this PR does πŸ“–

Self-explanatory

Which issue(s) this PR fixes πŸ”¨

AP-567

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: cbb3d08

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62065c025a5e0b0008520b03

😎 Browse the preview: https://deploy-preview-1455--adoring-edison-dbcef8.netlify.app

@netlify
Copy link

netlify bot commented Feb 11, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: adc5d85

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/620a6b5824fc2a00086ea12f

😎 Browse the preview: https://deploy-preview-1455--adoring-edison-dbcef8.netlify.app

libraries/ui/Commands.ts Outdated Show resolved Hide resolved
libraries/ui/Commands.test.ts Outdated Show resolved Hide resolved
@stavares843
Copy link
Member

minor comment

@WanderingHogan WanderingHogan added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 11, 2022
Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good after removing logs/multi line comment split

@stavares843
Copy link
Member

/rebase

@stavares843 stavares843 removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Feb 14, 2022
@stavares843 stavares843 merged commit 3d62cc5 into dev Feb 14, 2022
@stavares843 stavares843 deleted the AP-567 branch February 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants