Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outgoingFriends): alpha sort to outgoing friends AP-713 #1480

Merged
merged 1 commit into from
Feb 14, 2022
Merged

feat(outgoingFriends): alpha sort to outgoing friends AP-713 #1480

merged 1 commit into from
Feb 14, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Feb 14, 2022 •
edited
Loading

https://satellite-im.atlassian.net/browse/AP-713?filter=-1

What this PR does 📖

  • alphabetically sort outgoing friend requests. If we want to sort by letter into groups, let me know. from a UX perspective, I don't think it's necessary. it's nice to have on the friends list since a user may have many friends. I imagine they won't have too many outgoing friend requests at one time though

Which issue(s) this PR fixes 🔨
AP-713

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 14, 2022
@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: 5b5addb

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/620a0151b091fd0007b59e52

😎 Browse the preview: https://deploy-preview-1480--adoring-edison-dbcef8.netlify.app

@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 14, 2022
@stavares843
Copy link
Member

Captura de ecrã 2022-02-14, às 17 32 04

we also have that category stuff on the ones that are already on the list

@stavares843
Copy link
Member

curiosity, if you have 2 people with the exact same name, how does the order gets sorted?

@phillsatellite phillsatellite added Ready for QA Ready for QA team to test, Devs approved. QA tested One QA Person has tested - Needs QA Lead review still and removed QA tested One QA Person has tested - Needs QA Lead review still Ready for QA Ready for QA team to test, Devs approved. labels Feb 14, 2022
@stavares843 stavares843 changed the title feat(outgoingFriends): add alpha sort to outgoing friend requests AP-713 feat(outgoingFriends): alpha sort to outgoing friends AP-713 Feb 14, 2022
@stavares843 stavares843 merged commit 29b2a4b into dev Feb 14, 2022
@stavares843 stavares843 deleted the AP713 branch February 14, 2022 17:51
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jekrimo Jekrimo Jekrimo approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josephmcg @stavares843 @Jekrimo @molimauro @phillsatellite