Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user program): updated the app to use the new user program #1511

Merged
merged 8 commits into from
Feb 25, 2022
Merged

feat(user program): updated the app to use the new user program #1511

merged 8 commits into from
Feb 25, 2022

Conversation

iltumio
Copy link
Collaborator

@iltumio iltumio commented Feb 16, 2022

What this PR does 📖
Replace the previous User registration mechanism on Solana with the new User program implementation. Using a Program Derived Account for the user information, brings a lot of advantages like an easier integration with existing Solana wallets

Which issue(s) this PR fixes 🔨
AP-724

Special notes for reviewers 🗒️
🚨 BREAKING CHANGE 🚨 you have to delete and recreate your account in order to make it work.

To properly test this PR you should at least:

  • register a new account
  • send a new friend request to someone
  • accept/deny the friend request
  • remove a friend
  • check around the app if the user information are properly shown (name, status message, profile picture)

Additional comments 🎤
I am satoshi, but don't tell anyone

@netlify
Copy link

netlify bot commented Feb 16, 2022 •
edited
Loading

✔️ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: 8f5ff26

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6218daea177f940007b53103

😎 Browse the preview: https://deploy-preview-1511--adoring-edison-dbcef8.netlify.app

@molimauro molimauro added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 16, 2022
molimauro
molimauro reviewed Feb 16, 2022
View reviewed changes
config.ts Outdated Show resolved Hide resolved
@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 16, 2022
@molimauro
Copy link
Contributor

Just 2 typos, ok other than that 💥

@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Feb 16, 2022
@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Feb 17, 2022
@stavares843
Copy link
Member

/rebase

@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Feb 17, 2022
stavares843
stavares843 requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

your branch after sign up with the new account

image

same flow on dev branch locally works fine

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Feb 17, 2022
@iltumio iltumio added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Feb 17, 2022
@phillsatellite
Copy link
Contributor

Tested: Crash is gone but after starting on 2 new accounts seems when you try to send a friend request you get "hmm, we couldn't find that address" verified issue does not happen on local dev

friendrq.mov

@phillsatellite phillsatellite added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Feb 17, 2022
@iltumio iltumio added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 17, 2022
@iltumio iltumio added the Ready for QA Ready for QA team to test, Devs approved. label Feb 24, 2022
@Jekrimo Jekrimo removed the Needs Backend Review Need a review specifically from a Backend team member to progress label Feb 24, 2022
@phillsatellite
Copy link
Contributor

Hi Manuel I'm sorry to come with another issue ☹️ I tested, started from 2 new profiles, added each other and got "errors.friends.textile_not_initialized" attaching a photo of console as well
Screen Shot 2022-02-24 at 11 41 16 AM
Screen Shot 2022-02-24 at 11 41 20 AM

@phillsatellite phillsatellite added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Feb 24, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Feb 25, 2022
@iltumio iltumio added Ready for QA Ready for QA team to test, Devs approved. and removed missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Feb 25, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 25, 2022
@stavares843 stavares843 mentioned this pull request Feb 25, 2022
Closed
stavares843
stavares843 approved these changes Feb 25, 2022
View reviewed changes
store/accounts/actions.ts
* @example
* ```typescript
* this.$store.dispatch('accounts/initializeEncriptionEngin', currentUserAccount)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initializeEncriptionEngin vs initializeEncryptionEngine

@stavares843 stavares843 merged commit 2fe7ee1 into dev Feb 25, 2022
@stavares843 stavares843 deleted the AP-724 branch February 25, 2022 17:35
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Feb 25, 2022
@stavares843 stavares843 mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iltumio @molimauro @stavares843 @phillsatellite @WanderingHogan @Jekrimo