Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): 100% coverage for store/files/actions.ts #1512

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Feb 16, 2022

What this PR does πŸ“–

self-explanatory

Which issue(s) this PR fixes πŸ”¨

AP-571

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 16, 2022
@netlify
Copy link

netlify bot commented Feb 16, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: ec2fa2b

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/620cb7f4c9be5d00087562ac

😎 Browse the preview: https://deploy-preview-1512--adoring-edison-dbcef8.netlify.app

@stavares843
Copy link
Member

@drepram

@phillsatellite noticed this

image

and when repeating is the same

any thoughts why it takes 6 seconds on that one? πŸ”¨

@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 16, 2022
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Feb 16, 2022
@stavares843
Copy link
Member

actually @WanderingHogan took a look and explained it

thanks @WanderingHogan

@stavares843 stavares843 merged commit f8c6a5d into dev Feb 16, 2022
@stavares843 stavares843 deleted the AP-571 branch February 16, 2022 17:42
@github-actions github-actions bot removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants