fix(imageUpload): fixes uploaded images being added to the wrong chat when changing during NSFW check #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2022 18:57
…ou switch chats during NSFW check phase
molimauro
approved these changes
Feb 18, 2022
molimauro
added
Changes Requested
|
Can you add this line |
WanderingHogan
added
Ready for QA
josephmcg
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
assigns the address in the store for uploaded images to be the one from the time the upload is initiated, not the one at the time the file has finished processing.
Which issue(s) this PR fixes 🔨
Previously, changing chats while an image is in the NSFW check phase would cause it to get added to the wrong chat's files array. This fixes this.
Special notes for reviewers 🗒️
Additional comments 🎤
the store solution @josephmcg used for upload persists is a nice one that solves some problems I couldn't figure out how to work around, and investigating how his solution worked is what led me to finding this bug that would've affected both our solutions