Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): 88% coverage for store/ui/actions.ts #1596

Merged
merged 6 commits into from
Feb 22, 2022
Merged

feat(jest): 88% coverage for store/ui/actions.ts #1596

merged 6 commits into from
Feb 22, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Feb 21, 2022

What this PR does πŸ“–

Self-explanatory. Still a work in progress on that particular activateKeybinds function.

Which issue(s) this PR fixes πŸ”¨

AP-778

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Feb 21, 2022
@netlify
Copy link

netlify bot commented Feb 21, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: 64a828a

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6215091403732300079a6fe3

😎 Browse the preview: https://deploy-preview-1596--adoring-edison-dbcef8.netlify.app

store/ui/actions.ts Outdated Show resolved Hide resolved
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 21, 2022
@drepram drepram changed the title feat(jest): currently 52% coverage for store/ui/actions.ts feat(jest): 88% coverage for store/ui/actions.ts Feb 22, 2022
@drepram
Copy link
Contributor Author

drepram commented Feb 22, 2022

I've bumped the coverage from 52% to 88%. Also removed the Timezone unit for now because I reckon it'll fail the CI. Please take a look, thanks!

@stavares843
Copy link
Member

/rebase

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Feb 22, 2022
@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Feb 22, 2022
@WanderingHogan WanderingHogan merged commit 917f833 into dev Feb 22, 2022
@WanderingHogan WanderingHogan deleted the AP-778 branch February 22, 2022 17:47
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants