feat(jest): 42% coverage for libraries/IndexedDB AP-892 #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
|
✔️ Yeeeehaw, deploy preview is ready! 🔨 Explore the source changes: c315a68 🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6217a7a7cd3ad60008a3282f 😎 Browse the preview: https://deploy-preview-1687--adoring-edison-dbcef8.netlify.app |
stavares843
reviewed
Feb 24, 2022
| argumentQueryOptions, | ||
| ) | ||
| expect(db.conversations.bulkGet).toHaveBeenCalled() | ||
| console.log(result) |
There was a problem hiding this comment.
do we need this console.log? 🔨
stavares843
changed the title
stavares843
approved these changes
Feb 24, 2022
|
minor comment |
|
this is fine but don't add any coverage to the indexeddb work in the near term |
WanderingHogan
approved these changes
Feb 24, 2022
|
thanks @WanderingHogan |
|
we are re-working it all and the tests likely wont be valid |
github-actions
bot
removed
the
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Self-explanatory. The reason the coverage is not higher at the moment is that I need an actual mock (and an address) to simulate the forEach loops; I am currently asking David C for it.
Which issue(s) this PR fixes 🔨
AP-892
Special notes for reviewers 🗒️
Additional comments 🎤