-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filesLimit): handle if user goes over size limit #1715
Conversation
βοΈ Yeeeehaw, deploy preview is ready! π¨ Explore the source changes: b30eb44 π Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6221654ce037ea0008906923 π Browse the preview: https://deploy-preview-1715--adoring-edison-dbcef8.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool to see the progress bar updating upon file uploads! π Sadly do not currently have a 4GB file to test for if a user can continue to upload past that point.
I didn't either, I tested it by changing the limit to a smaller number |
Tested: works really well, the only bug I was able to find is if a user has stuff uploaded and the refresh they're page, all the files will still be there but the progress bar will be empty until a user uploads another file refresh.files.mov |
/rebase |
@phillsatellite Thanks Phil! should be fixed now |
thanks @josephmcg π¨ |
@stavares843 I noticed something I need to fix here, will cause bugs after file type support gets merged |
ok, now its good |
thanks π₯ |
/rebase |
|
that's true! maybe we could ask Liz about the 2 first questions as they are more UI/UX related |
@stavares843 issues above should be fixed. I was setting the loading state after checking filesize. It was working correctly in your video, it just takes a LONG time for files that large |
Do we want to display in terms of decimal or binary? Before, we were using binary for calculations, but using the decimal labels. |
thanks @josephmcg we could ask if there's any preference, either decimal or binary |
@josephmcg hello!! Last little problem I found on this branch, after updates MB and GB changed to MiB and GiB |
yes, they were using binary. just switched it to decimal |
What this PR does π
Which issue(s) this PR fixes π¨
AP-899, AP-910
Special notes for reviewers ποΈ
Additional comments π€