Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): 35% coverage for store/accounts/actions #1757

Merged
merged 17 commits into from
Mar 2, 2022
Merged

feat(jest): 35% coverage for store/accounts/actions #1757

merged 17 commits into from
Mar 2, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Mar 1, 2022

What this PR does πŸ“–

Self-explanatory PR, but am putting this ticket into the backlog because of the current issue with the .hash function.

Which issue(s) this PR fixes πŸ”¨

AP-661 (partially)

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 1, 2022
@netlify
Copy link

netlify bot commented Mar 1, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: d97e61b

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/621fa7698ba2e50008e85e70

😎 Browse the preview: https://deploy-preview-1757--adoring-edison-dbcef8.netlify.app

// 'fddd5093b61663c64c309a0352b3762e4f6b7277b1ec7f2ac64f4b696c66ab91',
// )
// CPrototype.decryptWithPassword = jest.fn()
// CPrototype.decryptWithPassword.mockReturnValueOnce('decrypted phrase')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this? πŸ”¨

@stavares843
Copy link
Member

/rebase

@stavares843
Copy link
Member

/rebase

@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 1, 2022
@stavares843 stavares843 removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 1, 2022
@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label Mar 2, 2022
@stavares843
Copy link
Member

/rebase

@stavares843 stavares843 merged commit 971708c into dev Mar 2, 2022
@stavares843 stavares843 deleted the AP-661 branch March 2, 2022 17:26
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants