Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): improved files error messages #2275

Merged
merged 1 commit into from
Mar 10, 2022
Merged

feat(files): improved files error messages #2275

merged 1 commit into from
Mar 10, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Mar 10, 2022

What this PR does πŸ“–

  • add small closable box for error messages

Which issue(s) this PR fixes πŸ”¨
AP-901

Special notes for reviewers πŸ—’οΈ

  • closing errors when you open a folder is kind of difficult due to the way components are setup. Is it ok now that it's closable?
  • I asked Liz about specific error messages. If she wants to change phrasing we can do it here or in a separate ticket.

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 10, 2022
@netlify
Copy link

netlify bot commented Mar 10, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: e84872c

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6229a3731f55de000993678b

😎 Browse the preview: https://deploy-preview-2275--adoring-edison-dbcef8.netlify.app

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Mar 10, 2022
@stavares843 stavares843 merged commit 94fdf90 into dev Mar 10, 2022
@stavares843 stavares843 deleted the AP901 branch March 10, 2022 15:36
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants