Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): 67% coverage for SearchIndex/index.ts #2313

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Mar 14, 2022

What this PR does πŸ“–

Self-explanatory. After some correspondence with Andrew, it seems that for now, we are not able to come up with a way to cover the remaining lines (consider too that it is prone to change).

Which issue(s) this PR fixes πŸ”¨

No tickets IIRC.

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@drepram drepram requested a review from aewing March 14, 2022 08:55
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: 584936d

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62337beee390df0008307800

😎 Browse the preview: https://deploy-preview-2313--adoring-edison-dbcef8.netlify.app

Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

libraries/SearchIndex/index.test.ts Outdated Show resolved Hide resolved
libraries/SearchIndex/index.test.ts Outdated Show resolved Hide resolved
libraries/SearchIndex/index.test.ts Outdated Show resolved Hide resolved
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Mar 14, 2022
@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Mar 15, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 16, 2022
@stavares843 stavares843 removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 17, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 17, 2022
@stavares843 stavares843 removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Mar 17, 2022
@WanderingHogan WanderingHogan merged commit 0c185d7 into dev Mar 17, 2022
@WanderingHogan WanderingHogan deleted the drepram/SearchIndex-jest branch March 17, 2022 18:34
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants