Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature messaging #235

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Conversation

iltumio
Copy link
Collaborator

@iltumio iltumio commented Nov 7, 2021

** Breaking Change **

Some changes in friends has been done since we are not sharing the mailbox id, but a textile provided public key for sending messages between users. For that reason the mailboxId property in User and Friend objects has been renamed as textilePublicKey.

To make it work properly it is needed to clear the storage and to create a new fresh user with new fresh friends.

Features:

  • Fetching direct conversations
  • Sending text messages
  • Sending reactions
  • Sending replies
  • Subscribe to new incoming messages (the subscription lasts 1 minute)

Known issues:

  • Textile mailbox needs some time to be initialized. The UI does not provide any feedback on that and allows to start using the chat before it is ready. This causes an exception in the console (Textile not yet initialized)
  • The subscription will be closed after 1 minute of inactivity

@InfamousVague
Copy link

@iltumio can we add initializing textile to the loading tasks on the loading screen? I'm not sure if we're bypassing that screen right now but we should be moving from the unlock screen to the loading screen so we can initialize all these things.

@InfamousVague InfamousVague merged commit 64003ea into Satellite-im:main Nov 10, 2021
InfamousVague pushed a commit that referenced this pull request Dec 5, 2021
* update: added real mailbox id to friend requests

* chore: textile messaging

* feat: text message, reactions and replies

* fix: updated the ui to be compatible with new messaging implementation

* feat: added mailbox subscription support

* chore: loading page until prerequisites are matched

* fix: username in the reaction tooltip
@iltumio iltumio deleted the feature-messaging branch January 5, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants