Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): fullscreen view swiper issue #2364

Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix(files): fullscreen view swiper issue #2364

merged 2 commits into from
Mar 18, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Mar 17, 2022 •
edited
Loading

What this PR does 📖

  • fix issue where fullscreen image view in filesystem would be shifted based on the sidebar toggle status

Which issue(s) this PR fixes 🔨
AP-913

Special notes for reviewers 🗒️
looked liked this before
image

Additional comments 🎤

  • should be easy to cleanup with Vue3 teleport later

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 17, 2022
@netlify
Copy link

netlify bot commented Mar 17, 2022 •
edited
Loading

✔️ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: 0d7c2ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/623382da6736a60008a42396

😎 Browse the preview: https://deploy-preview-2364--adoring-edison-dbcef8.netlify.app

@stavares843
Copy link
Member

/rebase

@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label Mar 17, 2022
@molimauro molimauro removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 18, 2022
@stavares843 stavares843 merged commit 0b1d1d5 into dev Mar 18, 2022
@stavares843 stavares843 deleted the AP913 branch March 18, 2022 15:40
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Mar 18, 2022
@josephmcg josephmcg mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephmcg @stavares843 @molimauro @phillsatellite