Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): 72% coverage for TextileFileSystem.ts #2409

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Mar 18, 2022

What this PR does πŸ“–

Self-explanatory. The way that I improved the unit test is by passing in an SVG file to satisfy the SVG condition on the module.

Which issue(s) this PR fixes πŸ”¨

Increasing coverage of AP-927

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 18, 2022
@stavares843
Copy link
Member

/rebase

@netlify
Copy link

netlify bot commented Mar 18, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: f1b13a3

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6234ca16387738000afd002e

😎 Browse the preview: https://deploy-preview-2409--adoring-edison-dbcef8.netlify.app

@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label Mar 18, 2022
@stavares843 stavares843 merged commit 01798d2 into dev Mar 18, 2022
@stavares843 stavares843 deleted the drepram/improve-textilefilesystem-jest branch March 18, 2022 20:39
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants