-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(importAccount): typeahead support using searchindex #2422
Conversation
β Yeeeehaw, deploy preview is ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/rebase |
54fa038
to
4dcbf52
Compare
@aewing the other PR was merged, is this one still draft? |
4dcbf52
to
fd27561
Compare
fd27561
to
5896dea
Compare
5896dea
to
15e92fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gravacao.do.ecra.2022-03-24.as.13.50.54.mov
this branch vs dev
import account is broken on this branch, video above
if you copy paste a whole key, only pastes the first word
Thanks for finding these. Addressing these issues this morning, will have some updates soon. |
15e92fd
to
0338ba3
Compare
0338ba3
to
358b864
Compare
this is reverting this modification we did - #1499 basically, the first keyword shouldn't be highlighted this branch dev |
I can revert this change, but I found this to be flow breaking personally. I might save a few keypresses by having the item selected automatically and being able to press enter to continue to the next word (which is what I am accustomed to as a user with typeahead inputs). Reviewing the linked ticket, there isn't much detail about the 'why' behind this, so I thought perhaps it was related to a bug with the dual states of mouse hover and keyboard which have been resolved. |
@phillsatellite can you provider clarity on what we were actually solving for with #1499? |
basically, the first word on that PR was always highlighted, and Alex fix that if you go to dev, the first word is not highlighted but on this PR, was being highlighted again basically we don't want words highlights when user is still searching unless user is hovering on those |
for speed's sake, not against in not reverting the above |
Yea, I see what you're saying. I'm just trying to understand why we would not want this behavior, as it is the default behavior for as-you-type/typeahead components everywhere. I will revert the change today, but thought it worth having the discussion because the default selection feels right to me as a user. |
358b864
to
96ccc75
Compare
I think this is good to go in if the functionality is there. The typeahead got very complex and it didn't need to be. We shouldn't add overrides for everything and try to steer towards using things without a million overrides |
sounds good π¨ |
π π |
What this PR does π
Implements a typeahead filter on the import account page
Which issue(s) this PR fixes π¨
AP-322
Special notes for reviewers ποΈ
Made some changes to the active item logic:
Additional comments π€
extends #2179