Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slimbar): create unread user component #2475

Merged
merged 4 commits into from
Mar 25, 2022
Merged

feat(slimbar): create unread user component #2475

merged 4 commits into from
Mar 25, 2022

Conversation

AlexZakablukov
Copy link
Contributor

What this PR does 📖
create unread user component that display the new messages count, play sounds, show a custom context menu on mouse right click, show tooltip when hovered

Which issue(s) this PR fixes 🔨
AP-1141

Special notes for reviewers 🗒️

Additional comments 🎤

@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 23, 2022
@netlify
Copy link

netlify bot commented Mar 23, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 7045d57
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/623d9425b04d92000815d659
😎 Deploy Preview https://deploy-preview-2475--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@phillsatellite
Copy link
Contributor

Tested: Should this be functional? I do get sound feedback but when I try to use the quick menu doesnt seem to be functional right now

functional.mov

@phillsatellite phillsatellite added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Mar 23, 2022
@AlexZakablukov
Copy link
Contributor Author

Tested: Should this be functional? I do get sound feedback but when I try to use the quick menu doesnt seem to be functional right now

functional.mov

I don't know what functional exactly should be in context menu. Maybe @molimauro knows?

@molimauro
Copy link
Contributor

Tested: Should this be functional? I do get sound feedback but when I try to use the quick menu doesnt seem to be functional right now
functional.mov

I don't know what functional exactly should be in context menu. Maybe @molimauro knows?

Can you replicate the same in the friends list in the sidebar?

@AlexZakablukov
Copy link
Contributor Author

fixed

@AlexZakablukov
Copy link
Contributor Author

add active state for selected unread and revert sound effect place

@molimauro
Copy link
Contributor

Thanks @AlexZakablukov great job

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Mar 24, 2022
stavares843
stavares843 requested changes Mar 24, 2022
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-03-24, às 13 37 25

Captura de ecrã 2022-03-24, às 13 38 28

on mobile browser, the fake chats on the slim bar appear, they don't appear on desktop

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Mar 24, 2022
@AlexZakablukov
Copy link
Contributor Author

@stavares843
image

@stavares843
Copy link
Member

ohh lol I thought it wasn't the same 😂

thanks for checking @AlexZakablukov

I thought the colored ones were fake hidden chats lol, I'm gonna add a ticket for those to be grey out then 🔨

@stavares843 stavares843 added Ready for QA Ready for QA team to test, Devs approved. Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. Ready for QA Ready for QA team to test, Devs approved. labels Mar 24, 2022
@stavares843
Copy link
Member

Gravacao.do.ecra.2022-03-24.as.14.39.30.mov

on the mobile browser, if you press on the user the hover gets hidden

Captura de ecrã 2022-03-24, às 14 40 37

@AlexZakablukov
Copy link
Contributor Author

AlexZakablukov commented Mar 24, 2022 •
edited
Loading

Gravacao.do.ecra.2022-03-24.as.14.39.30.mov
on the mobile browser, if you press on the user the hover gets hidden

Captura de ecrã 2022-03-24, às 14 40 37

@stavares843 I can disable hover effect on mobile and leave only active state. Would it be a good solution? Also I think I have to move tooltip with name to bottom or remove it on mobile

@stavares843
Copy link
Member

sounds good @AlexZakablukov

removing the hover tip on mobile seems a good idea

@AlexZakablukov
Copy link
Contributor Author

fixed

@molimauro molimauro added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Mar 25, 2022
@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Mar 25, 2022
@stavares843 stavares843 merged commit 405fafb into dev Mar 25, 2022
@stavares843 stavares843 deleted the AP-1141 branch March 25, 2022 16:23
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexZakablukov @phillsatellite @molimauro @stavares843