Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): better archive file check #2639

Merged
merged 2 commits into from
Mar 30, 2022
Merged

fix(files): better archive file check #2639

merged 2 commits into from
Mar 30, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Mar 30, 2022 •
edited
Loading

What this PR does 📖

  • accurately show archive icon in filesystem, even in case of rename. uses new utility function added in a separate PR
  • clean up type errors, improve doc
  • remove unused regex from config

Which issue(s) this PR fixes 🔨
AP-1155

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 30, 2022
@netlify
Copy link

netlify bot commented Mar 30, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 8fe7ec9
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/624410c9d1c27e000893e325
😎 Deploy Preview https://deploy-preview-2639--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Mar 30, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. labels Mar 30, 2022
@stavares843 stavares843 added the temporary blocked checking something QA Lead is checking something. label Mar 30, 2022
@stavares843 stavares843 merged commit 7cb2bbe into dev Mar 30, 2022
@stavares843 stavares843 deleted the AP1155 branch March 30, 2022 17:27
@github-actions github-actions bot removed QA tested One QA Person has tested - Needs QA Lead review still temporary blocked checking something QA Lead is checking something. labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@josephmcg @Jekrimo @stavares843 @molimauro @phillsatellite