fix(files): rework store for files modal #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
β Yeeeehaw, deploy preview is ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Yeeeehaw, deploy preview is ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
missing fixing conflict
josephmcg
removed
the
missing fixing conflict
Jekrimo
approved these changes
Apr 7, 2022
phillsatellite
approved these changes
Apr 7, 2022
phillsatellite
added
the
QA tested
molimauro
approved these changes
Apr 8, 2022
molimauro
removed
the
Missing Dev Review
stavares843
force-pushed
the
filesFix
branch
2 times, most recently
from
1e6635e
to
fe73340
Compare
stavares843
requested changes
Apr 8, 2022
stavares843
added
Changes Requested
|
This does not impact chat messages |
josephmcg
added
Ready for QA
|
if doesn't impact chat messages, why the difference in behavior above? @josephmcg |
stavares843
added
Changes Requested
|
I would suggest getting the latest rebased branch and running it locally, they're not my changes so I have no idea why chat is acting like that |
|
seems like our netlify pipeline takes commits from everywhere? idk, i never use it besides mobile testing. that would support the 'someone else's code' theory. |
josephmcg
added
Ready for QA
|
the netlify commits are the ones on this branch, it takes this branch code changes and then deploys to netlify but I can test locally as well |
|
checked locally and now is fine and has the same behavior in both dev and this branch thanks for checking π¨ |
stavares843
approved these changes
Apr 11, 2022
github-actions
bot
removed
the
Ready for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does π
Which issue(s) this PR fixes π¨
Special notes for reviewers ποΈ
Additional comments π€