fix(message): update timestamp message every minute #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavares843
added
Missing Dev Review
stavares843
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
so it no longer gets stuck showing a few seconds ago
when sending a message says a few seconds ago and then updates to a minute ago, 2 minutes ago, and so on
but the thing is, when you send a message and then wait 5 minutes and send another message, all those messages shows that were sent 5 minutes ago, even if the oldest one was 5m ago and the newest one was a couple of seconds ago
I'm gonna approve this because that's probably to be handled on other PR, let me know cc @WanderingHogan
stavares843
added
QA tested
QA tested
|
@stavares843 just added a few tickets to address what you brought up: AP-106 and AP-107 |
WanderingHogan
approved these changes
Nov 24, 2021
InfamousVague
requested changes
Nov 24, 2021
| refreshTimestampEveryMinute() { | ||
| this.timestampRefreshInterval = setInterval(() => { | ||
| this.$data.timestamp = this.$dayjs(this.group.at).from() | ||
| }, 60 * 1000) |
There was a problem hiding this comment.
Can we move this to a config value?
| refreshTimestampEveryMinute() { | ||
| this.timestampRefreshInterval = setInterval(() => { | ||
| this.$data.timestamp = this.$dayjs(this.$props.message.at).from() | ||
| }, 60 * 1000) |
There was a problem hiding this comment.
I suggest
chat: {
defaultMessageLimit: 50,
defalutLoadMoreLimit: 20,
timestampUpdateInterval: 60 * 1000,
},
stavares843
added
Changes Requested
stavares843
added
Missing Dev Review
InfamousVague
approved these changes
Nov 26, 2021
InfamousVague
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <eric.lee6174@gmail.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Chris Hogan <chris@hogan.io>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 1, 2021
… Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <eric.lee6174@gmail.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Chris Hogan <chris@hogan.io> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <36959970+iltumio@users.noreply.github.com> Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Nick <81814644+nickjjang@users.noreply.github.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Chris Hogan <chris@hogan.io>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 2, 2021
* fix(chat): fix 'unable to paste text into chat' * chore(textile-store): update textile convo to have timestamps on top level (#328) * chore(textile-store): update textile convo to have timestamps on top level Added timestamps for user and convo on conversations * chore(documentation/enums): update enums and add inline documentation * feat(import account): 'Create Import Account Page, linked from Import Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <eric.lee6174@gmail.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Chris Hogan <chris@hogan.io> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <36959970+iltumio@users.noreply.github.com> Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Nick <81814644+nickjjang@users.noreply.github.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Chris Hogan <chris@hogan.io> * fix(chat): fix 'unable to paste text into chat' * fix(chat): fix spacing issue on chatbar Co-authored-by: Chris Hogan <chris@hogan.io> Co-authored-by: Manuel Tumiati <36959970+iltumio@users.noreply.github.com> Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Nick <81814644+nickjjang@users.noreply.github.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
* chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
* Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <eric.lee6174@gmail.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Chris Hogan <chris@hogan.io>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
… Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <eric.lee6174@gmail.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Chris Hogan <chris@hogan.io> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <36959970+iltumio@users.noreply.github.com> Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Nick <81814644+nickjjang@users.noreply.github.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Chris Hogan <chris@hogan.io>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
* fix(chat): fix 'unable to paste text into chat' * chore(textile-store): update textile convo to have timestamps on top level (#328) * chore(textile-store): update textile convo to have timestamps on top level Added timestamps for user and convo on conversations * chore(documentation/enums): update enums and add inline documentation * feat(import account): 'Create Import Account Page, linked from Import Account button' (#327) * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(webrtc): add low level abstractions for handling p2p connections and audio/video calls (#324) * wip: WebRTC implementation * chore: better structure * chore: documented all methods * fix: prettier config * fix: replaced p2pt dependency with the internal one * Update encoders.ts * fix: typos in comments and comma dangle Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore: update linting rules (#326) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) (#318) * Feat(Timestamp): Add timestamp to Message Actions (AP-106) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' (#306) * fix(chat reaction): Fix 'Emoji reactions will increase if user navigates to a different page and back to chat again' * put space after if * fix(message): update timestamp message every minute (#300) * chore: rebase dev * chore(message): changes in response to pr review Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> * implements lazy loading for glyphs - AP-101 (#311) * (update)glyphs: add vuetify import * update(lazy load glyphs): update implemintation of glyphs to allow lazy loading brought in from vuetify. * Nuke old code * nuke old code * fix - Duplicate friends are being added when page is re-rendered - AP-64 (#308) * fixed duplicated friends issue = AP-64 * Update actions.ts Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> * chore(readme): doc update (#319) Updating readme Adding .env.example file Updated satellite-lucide-icons to not need ssh key uploaded to github closes no tickets * fix merge conflict * Fix messageOwner in Action html * fix(Timestamp): removed messageOwner in Action components * fix(timestamp): add comma dangle Co-authored-by: Eric Lee <eric.lee6174@gmail.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Chris Hogan <chris@hogan.io> * Chat Window Status Bar User Info - #AP-109 (#323) * feat(Import Account): add remove option for numberedword component * feat(import account): enable import account button * feat(import account): add input account component * feat(import account): disable recover button if phrases.length < 12, update number word style * feat(Import Account): add remove option for numberedword component * feat(Import Account): fix routing issue in authenticated middleware Co-authored-by: Manuel Tumiati <36959970+iltumio@users.noreply.github.com> Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Nick <81814644+nickjjang@users.noreply.github.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com> Co-authored-by: Chris Hogan <chris@hogan.io> * fix(chat): fix 'unable to paste text into chat' * fix(chat): fix spacing issue on chatbar Co-authored-by: Chris Hogan <chris@hogan.io> Co-authored-by: Manuel Tumiati <36959970+iltumio@users.noreply.github.com> Co-authored-by: Matt Wisniewski <contact.mattdylan@gmail.com> Co-authored-by: Matt Wisniewski <retropronghorn@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Nick <81814644+nickjjang@users.noreply.github.com> Co-authored-by: vimercati-samir <52865716+vimercati-samir@users.noreply.github.com> Co-authored-by: Samir Vimercati <samir.vimercati@knobs.it> Co-authored-by: Jeff Kristian <jekrimo@gmail.com> Co-authored-by: David Chan <57536961+davidchan1219@users.noreply.github.com>
stavares843
removed
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Update timestamp message every minute
Which issue(s) this PR fixes 🔨
timestamp message not updating (‘A few seconds ago' for ever unless component rebuilds)
Fixes #AP-43
Special notes for reviewers 🗒️
Additional comments 🎤