Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): stop alert notification if alert would notify of message of current active chat #3267

Merged
merged 3 commits into from
May 30, 2022
Merged

fix(notifications): stop alert notification if alert would notify of message of current active chat #3267

merged 3 commits into from
May 30, 2022

Conversation

Jekrimo
Copy link
Contributor

@Jekrimo Jekrimo commented May 23, 2022

What this PR does 📖
Don't have alert for chat that is active

Which issue(s) this PR fixes 🔨

AP-1502

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 23, 2022
@netlify
Copy link

netlify bot commented May 23, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 8302479
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6291028400ffab0008900ae6
😎 Deploy Preview https://deploy-preview-3267--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label May 24, 2022
josephmcg
josephmcg reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@josephmcg josephmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the decision to change alert.state into a configurable param? Currently, we only have READ or UNREAD. Is there a plan to create other states, or is there a use case where we want to create a READ alert?

@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels May 26, 2022
@Jekrimo
Copy link
Contributor Author

Jekrimo commented May 26, 2022

I can foresee both needing to happen honestly. Like an app update alert that auto pops up on launch, still an alert, but they are forced to see it originally so it's already read.

@josephmcg
Copy link
Contributor

Thanks, was just curious. Sounds good

@josephmcg josephmcg removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label May 26, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. temporary blocked checking something QA Lead is checking something. and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. QA tested One QA Person has tested - Needs QA Lead review still temporary blocked checking something QA Lead is checking something. labels May 26, 2022
@phillsatellite
Copy link
Contributor

Hey Jeff! I went in and retested and found one small issue, the red badge that appears on alerts isnt showing up for me for some reason (I'm in a different chat when receiving messages) I did a new server and also tried replicating on dev branch as well. When I do open alerts all the messages that were coming in appear there just no red badge no matter which chat you are in

alerts.notification.mov

@phillsatellite phillsatellite added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels May 27, 2022
@Jekrimo
Copy link
Contributor Author

Jekrimo commented May 27, 2022

Hey Jeff! I went in and retested and found one small issue, the red badge that appears on alerts isnt showing up for me for some reason (I'm in a different chat when receiving messages) I did a new server and also tried replicating on dev branch as well. When I do open alerts all the messages that were coming in appear there just no red badge no matter which chat you are in

alerts.notification.mov

what the freaking heck

@Jekrimo
Copy link
Contributor Author

Jekrimo commented May 27, 2022

Hey Jeff! I went in and retested and found one small issue, the red badge that appears on alerts isnt showing up for me for some reason (I'm in a different chat when receiving messages) I did a new server and also tried replicating on dev branch as well. When I do open alerts all the messages that were coming in appear there just no red badge no matter which chat you are in

alerts.notification.mov

Should be fixed now! Dumb fix

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels May 27, 2022
@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label May 27, 2022
@phillsatellite
Copy link
Contributor

@Jekrimo worked perfect on my end, and amazing response time with the fix 😂

@molimauro molimauro removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 30, 2022
@stavares843 stavares843 merged commit 4e28935 into dev May 30, 2022
@stavares843 stavares843 deleted the AP-1502 branch May 30, 2022 17:16
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg left review comments

@drepram drepram drepram left review comments

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jekrimo @josephmcg @phillsatellite @stavares843 @drepram @molimauro