Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(friends): show error toast if friend request not found #3308

Merged
merged 4 commits into from
May 30, 2022
Merged

Conversation

jasonwoodland
Copy link
Contributor

What this PR does πŸ“–

  • Removes a superfluous throw
  • Displays an error toast if the friend request isn't found

Which issue(s) this PR fixes πŸ”¨
AP-1565

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 26, 2022
@netlify
Copy link

netlify bot commented May 26, 2022

βœ… Yeeeehaw, deploy preview is ready!

Name Link
πŸ”¨ Latest commit c9bfb95
πŸ” Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629538a8652df200085f4379
😎 Deploy Preview https://deploy-preview-3308--adoring-edison-dbcef8.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jekrimo Jekrimo removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 26, 2022
@josephmcg josephmcg added the Ready for QA Ready for QA team to test, Devs approved. label May 26, 2022
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels May 26, 2022
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-05-26, às 15 40 21

still happens

same flow as the one on the ticket πŸ”¨

@jasonwoodland
Copy link
Contributor Author

@stavares843 Fixed, I missed the event where you would try and cancel a friend request which was already accepted.

@jasonwoodland jasonwoodland removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label May 30, 2022
@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 30, 2022
@@ -99,7 +99,7 @@ export default Vue.extend({
})
} catch (e: any) {
this.loadCheck = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be removed but not important

@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels May 30, 2022
@stavares843 stavares843 merged commit 589d5f8 into dev May 30, 2022
@stavares843 stavares843 deleted the AP1565 branch May 30, 2022 21:36
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants