Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toast): add error toast styling #3314

Merged
merged 1 commit into from
May 31, 2022
Merged

feat(toast): add error toast styling #3314

merged 1 commit into from
May 31, 2022

Conversation

jasonwoodland
Copy link
Contributor

What this PR does 📖
Makes error toasts red

Which issue(s) this PR fixes 🔨
AP-1639

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 27, 2022
@netlify
Copy link

netlify bot commented May 27, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit e46e710
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6294ea6cd0ad910009c3a0fc
😎 Deploy Preview https://deploy-preview-3314--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

josephmcg
josephmcg suggested changes May 27, 2022
View reviewed changes
Copy link
Contributor

@josephmcg josephmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me, but let's confirm with Liz

@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels May 27, 2022
stavares843
stavares843 reviewed May 27, 2022
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with Joe,

also, is this for only error toasts or also the informative ones? example when we copy a ID on the friends section

@jasonwoodland
Copy link
Contributor Author

@stavares843 the copying id one is still blue, just the toasts called with $toast.error will appear red

@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels May 30, 2022
@WanderingHogan
Copy link
Contributor

easy to overwrite in any theme, uses var, good job!

@WanderingHogan
Copy link
Contributor

you can test this with window.$nuxt.context.$toast.error('hi') in the chrome console

@stavares843
Copy link
Member

thanks @WanderingHogan 🔨

@stavares843 stavares843 merged commit ee8e5b6 into dev May 31, 2022
@stavares843 stavares843 deleted the AP1639 branch May 31, 2022 00:58
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg requested changes

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasonwoodland @WanderingHogan @stavares843 @josephmcg